Fix 'One or more parameters passed to a function were not valid.' in …#206
Open
rpoelstra wants to merge 4 commits intosethmlarson:mainfrom
Open
Fix 'One or more parameters passed to a function were not valid.' in …#206rpoelstra wants to merge 4 commits intosethmlarson:mainfrom
rpoelstra wants to merge 4 commits intosethmlarson:mainfrom
Conversation
Author
|
@sethmlarson Can you please look into this? |
Owner
|
@rpoelstra Thanks for the pull request, could you add a test case so we verify this behavior continues to work? |
Author
|
Hi @sethmlarson, I've added a test. I noticed that there is another test failing, but this test also fails on an unmodified 'main', so it's not caused by this PR. |
sethmlarson
reviewed
Mar 23, 2026
| cert_chain: list[bytes], | ||
| server_hostname: str | None = None, | ||
| ) -> None: | ||
| certs = None |
Owner
There was a problem hiding this comment.
certs = None defined below, too.
…case there are no certificates to verify. This mimics the Windows implementation. Signed-off-by: Remco Poelstra <remco@beryllium.net>
Makes the code more DRY and reduces general code in OS specific implementations Signed-off-by: Remco Poelstra <remco@beryllium.net>
…ror when no peer certificates are returned, and that verification does not proceed further. Signed-off-by: Remco Poelstra <remco@beryllium.net>
Signed-off-by: Remco Poelstra <remco@beryllium.net>
rpoelstra
force-pushed
the
fix/no-certs-to-verify-macOS
branch
from
4b4bc42 to
02d7a93
Compare
Author
|
@sethmlarson I've pushed new commits, which I've signed with my private key to make sure they are verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…case there are no certificates to verify.
This mimics the Windows implementation by performing the emptiness check in the caller.
This issue is reported in #205 and #204